feat(badge): add recipe and tokens#31043
Merged
thetaPC merged 98 commits intoionic-modularfrom May 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
commented
Apr 6, 2026
Comment on lines
-59
to
-61
| :host ::slotted(ion-badge[vertical]:not(:empty)) { | ||
| @include globals.padding(2px); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Removed this completely because based on MD3, the padding should always be consistent regardless of the host component.
thetaPC
commented
Apr 22, 2026
|
|
||
| /** | ||
| * @virtualProp {"ios" | "md"} mode - The mode determines the platform behaviors of the component. | ||
| * @virtualProp {"ios" | "md" | "ionic"} theme - The theme determines the visual appearance of the component. |
Contributor
Author
There was a problem hiding this comment.
Forgot to remove this in the first iteration of review.
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Most of my feedback is related to styles and tests. 👍
Member
There was a problem hiding this comment.
Same issue here with badges being cut off. Apologies if you already added this to the tab bar and told me. 😅
Member
There was a problem hiding this comment.
It still looks cut off to me but we can fix it on tab bar:
Contributor
Author
There was a problem hiding this comment.
Ah, I misunderstood, thinking you meant that they cut off of the screen. Yes, I plan to revisit this when we migrate tab button.
ShaneK
requested changes
Apr 30, 2026
Co-authored-by: Shane <561207+ShaneK@users.noreply.github.com>
…nect Co-authored-by: Shane <561207+ShaneK@users.noreply.github.com>
Co-authored-by: Shane <561207+ShaneK@users.noreply.github.com>
Co-authored-by: Shane <561207+ShaneK@users.noreply.github.com>
ShaneK
approved these changes
May 1, 2026
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
All of my issues have been resolved, all that's left is Brandy's stuff! Great work!
brandyscarney
approved these changes
May 1, 2026
Member
brandyscarney
left a comment
brandyscarney
left a comment
There was a problem hiding this comment.
Great work on this!! Really love the updates to get us closer to native. 🙌 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Component styles for
ion-badgeare fragmented across multiple files (ios, md). Developers were restricted to those themes and how those themes structured the logic and styles.What is the new behavior?
badge.scssfile that consumes CSS variables, ensuring a single source of truth for component logic.badge.interfaces.tsDoes this introduce a breaking change?
This PR introduces a breaking change to how
IonBadgeis styled. Existing manual CSS overrides targeting internal badge structures or old token names will no longer work due to the shift to thew new token hierarchy and a unified base SCSS file.Migration Path:
Token Updates: Update any custom theme configurations to match the new nested structure.
CSS Overrides: Ensure selectors align with the new slotted element logic and variable names (e.g.,
--ion-badge-hue-bold-default-background).--backgroundshould no longer be used. Setting the value,Badge.hue.bold.background, within the tokens file should be used to change the background for the bold hue. Setting the value,Badge.hue.subtle.background, within the tokens file should be used to change the background for the subtle hue.badge.mdOther information
This PR significantly improves the developer experience for theming. By moving logic into
default.tokens.tsand away from hardcoded SCSS functions, designers and developers can now override styles (like the size on a slotted avatar) purely through token configuration.